[EuiDataGrid] Introduce a renderCustomToolbar render prop#7150
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_7150/ |
💔 Build Failed
Failed CI Steps |
|
@kertal @timductive What happened here? Why did this PR get merged in with failing CI checks, missing QA checklists, and zero review from the EUI team? If y'all want to take over datagrid and responsibility for its maintenance - awesome. Let's talk about moving it out of the EUI codebase first. |
|
Ah, wait, I see - this merged into a feature branch and not into This generally isn't the way we prefer to handle feature branches. If each individual PR into the feature branch is thoroughly and atomically reviewed/QA'd, the final (usually large) feature branch merge doesn't need more than a quick confidence/smoke check. Can you let us know what the plan is for this work and how you'd like us to work with you on it? I was planning on reviewing Matthias's PR and am happy to work with y'all on that, but if you'd prefer something else, happy to chat about it. |
|
@cee-chen Ooops, sorry for the confusion. The issue @timductive was working on was labeled as "help wanted". The issue became redundant with our conversation to use And it seems both out way creating PRs were creating branches on EUI and not on our forks, which should be done differently ideally. Happy to have a chat with you how we can bring this over the finishing line 👍 |
Summary
This PR is introducing a renderCustomToolbar render prop allowing the customize EuiDataGrid
QA
Remove or strikethrough items that do not apply to your PR.
General checklist
@defaultif default values are missing) and playground toggles