[React 18] Fix cross-version compatibility and unit test errors#7002
Merged
tkajtoch merged 16 commits intoelastic:feature/react-18from Jul 26, 2023
Merged
Conversation
cee-chen
approved these changes
Jul 26, 2023
Contributor
cee-chen
left a comment
There was a problem hiding this comment.
Inline Edit tests pass for me locally much faster than they did before - thanks for cleaning up those promises 😅
Here's hoping neither GitHub nor Jenkins are attacked by gremlins this time... 🤞
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_7002_buildkite/ |
1 similar comment
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_7002_buildkite/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_7002/ |
67e7112 to
cf8bb89
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_7002_buildkite/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_7002/ |
Collaborator
tkajtoch
added a commit
that referenced
this pull request
Jul 28, 2023
tkajtoch
added a commit
that referenced
this pull request
Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note that these changes were already reviewed (until this commit) in #6994 but github couldn't see the latest commit in
refs/pull/6994or trigger CI.This PR fixes all remaining unit tests, removes unused useRenderToText() internal utility and fixes code style in a few files I missed that were merged before (sorry!!)
QA
rm -rf node_modules && yarnyarn lintyarn test-unitREACT_VERSION=17 yarn test-unit