[EuiDataGrid] Safari workaround for cell actions hover animation#6881
Merged
cee-chen merged 3 commits intoelastic:mainfrom Jun 29, 2023
Merged
[EuiDataGrid] Safari workaround for cell actions hover animation#6881cee-chen merged 3 commits intoelastic:mainfrom
cee-chen merged 3 commits intoelastic:mainfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6881/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6881/ |
tkajtoch
approved these changes
Jun 29, 2023
Member
tkajtoch
left a comment
There was a problem hiding this comment.
Thanks for fixing it, it must've been a hard one to figure out!
Code looks good, tested on latest Chrome and Safari against PR env and latest release for comparison
Contributor
Author
|
Thanks Tomasz! Yeah, that was a fun one. The fine folks at the webkit bugzilla repository got back to me and said this bug/behavior is fixed in Safari 17, so we should be able to just revert this workaround/commit wholesale once Safari is on v17. 🤞 |
1Copenut
added a commit
to elastic/kibana
that referenced
this pull request
Jul 11, 2023
`eui@83.0.0` ⏩ `83.1.0` --- ## [`83.1.0`](https://github.com/elastic/eui/tree/v83.1.0) - Added `placeholder` prop to `EuiInlineEdit` ([#6883](elastic/eui#6883)) - Added `sparkles` glyph to `EuiIcon` ([#6898](elastic/eui#6898)) **Bug fixes** - Fixed Safari-only bug for single-line row `EuiDataGrid`s, where cell actions on hover would overlap instead of pushing content to the left ([#6881](elastic/eui#6881)) - Fixed `EuiButton` not correctly merging in passed `className`s with its base `.euiButton` class ([#6887](elastic/eui#6887)) - Fixed `EuiIcon` not correctly passing the `style` prop custom `img` icons ([#6888](elastic/eui#6888)) - Fixed multiple components with child props (e.g. `buttonProps`, `iconProps`, etc.) unsetting EUI's Emotion styling if custom `css` was passed to the child props object ([#6896](elastic/eui#6896)) **CSS-in-JS conversions** - Converted `EuiHeader` and `EuiHeaderLogo` to Emotion ([#6878](elastic/eui#6878)) - Removed Sass variables `$euiHeaderDarkBackgroundColor`, `$euiHeaderBorderColor`, and `$euiHeaderBreadcrumbColor` ([#6878](elastic/eui#6878)) - Removed Sass mixin `@euiHeaderDarkTheme` ([#6878](elastic/eui#6878))
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #6851
Problem
For some incredibly bizarre reason, Safari doesn't correctly update the flex width of the cell content (when rows are an undefined height/single flex row), which causes the action icons to overlap the content and makes the content less readable even when there is room for both the cell content and cell actions.
Solution
This workaround "animation" forces a rerender of the flex content width after the cell actions are done animating in. If the duration time is reduced, the fix becomes flaky/intermittent, occasionally working and occasionally not. No, I do not understand why 💀
I've filed a bug for Safari for this behavior here: https://bugs.webkit.org/show_bug.cgi?id=258539
QA
General checklist