[Emotion] Convert EuiKeyPadMenu (Menu component only) to Emotion#6636
Merged
cee-chen merged 5 commits intoelastic:mainfrom Mar 27, 2023
Merged
[Emotion] Convert EuiKeyPadMenu (Menu component only) to Emotion#6636cee-chen merged 5 commits intoelastic:mainfrom
EuiKeyPadMenu (Menu component only) to Emotion#6636cee-chen merged 5 commits intoelastic:mainfrom
Conversation
37 tasks
EuiKeyPadMenu (Menu component only) to Emotion
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6636/ |
2 tasks
child elements should use `__`, not the `--` modifier syntax
cee-chen
approved these changes
Mar 27, 2023
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6636/ |
breehall
added a commit
to elastic/kibana
that referenced
this pull request
Mar 30, 2023
# Summary eui@76.3.0 ⏩ eui@76.4.0 ## [`76.4.0`](https://github.com/elastic/eui/tree/v76.4.0) **CSS-in-JS conversions** - Converted `EuiKeyPadMenu` (Menu component only) to Emotion ([#6636](elastic/eui#6636)) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is PR 1/2 to convert
EuiKeyPadMenuto Emotion. This PR takes care of convertingEuiKeyPadMenuand a PR will come later to convertEuiKeyPadMenuItem.Note:
EuiKeyPadMenuvariables were not removed as they are still being used byEuiKeyPadMenuItem.QA
Remove or strikethrough items that do not apply to your PR.
General checklist
Emotion conversion checklist
- [ ] Checked component playground (class components wrapped inwithEuiThemeneed to passtrueas the second argument to itspropUtilityForPlaygroundinsrc-docs/src/views/{component}/playground.js)shouldRenderCustomStyles()test was added and passes with parent component and any nestedchildProps(e.g.tooltipProps)- [ ] Removed anymount()ed snapshots in favor ofrender()or a more specific assertion$euiSizetoeuiTheme.size.base) No: `EuiKeyPadMenuItem still needs themcalc()tomathWithUnitsif possible (if mixing different unit types, this may not be possible)- [ ] Added an@warndeprecation message within theglobal_styling/mixins/{component}.scssfilesrc/components/index.scss- [ ] Deleted anysrc/amsterdam/overrides/{component}.scssfiles (styles within should have been converted to the baseline Emotion styles)- [ ] Wrapped all animations or transitions ineuiCanAnimategapproperty to add margin between items if using flex-inlineand-blocklogical properties (check inline styles as well as CSS)euiComponent,euiComponent__child)- [ ] Deleted any modifier classNames or maps if not being used in Kibana. Before doing this step:**/target, **/*.snap, **/*.storyshotfor less noise) foreui{Component}(case sensitive) to find:Checked in Kibana and the snapshots / style updates are for
EuiKeyPadMenuItem, notEuiKeyPadMenueuiBadgeclass on a div instead of simply using theEuiBadgecomponent)- [ ] Documentation pass:- [ ] Converted any remaining.jsdocs files to TS- [ ] Misc cleanup of docs code (e.g. combine imports to singlefrom '../src', replace<React.Fragment>with<>)- [ ] Check for issues in the backlog that could be a quick fix for that component- [ ] Optional component/code cleanup: consider splitting up the component into multiple children if it's overly verbose or difficult to reason about