[EuiSelectable] Fix incorrect aria-posinset indices#6571
Merged
cee-chen merged 5 commits intoelastic:mainfrom Feb 2, 2023
Merged
[EuiSelectable] Fix incorrect aria-posinset indices#6571cee-chen merged 5 commits intoelastic:mainfrom
aria-posinset indices#6571cee-chen merged 5 commits intoelastic:mainfrom
Conversation
- I'm doing this because I'll need RTL's `rerender` props setting in the future, which Enzyme's `render` does not support
- this new logic correctly accounts for group labels not at the start of the options array + perf bonus - this array iteration now only happens once per rerender, as opposed to happening on every single item/option render - could likely be further optimized to only rerun when `visibleOptions` or `options` change, but I think this incremental improvement is fine for now
This reverts commit ad05c15.
Contributor
Author
|
@1Copenut Once staging is up, do you mind giving this a quick screen reader pass to make sure everything's working correctly when you have a quick sec? 🙇 |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6571/ |
1 similar comment
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6571/ |
Contributor
Author
|
I've been making Trevor do a lot of reviews lately, so CCing @Heenawter as well in case she wants to help QA/confirm the fix 😄 |
Heenawter
approved these changes
Feb 1, 2023
Contributor
There was a problem hiding this comment.
Did a quick review of the code and double checked that the the aria-posinset property of each item in the https://eui.elastic.co/pr_6571/#/forms/selectable#the-basics example was set correctly - everything seems correct to me! Thanks so much for tackling this so quickly 🎉
1Copenut
approved these changes
Feb 1, 2023
Contributor
1Copenut
left a comment
There was a problem hiding this comment.
👍 This passes an axe check on Chrome latest (MacOS). I tested VoiceOver using Safari and Firefox. Safari is handling the counts correctly as outlined in the MDN aria-setsize documentation.
VO + Firefox does some unexpected (to me) counting, but that behavior was observed on production too, so not a regression. It's entirely possible VO + Firefox users are used to this behavior and consider it correct; I don't have enough information to flag it as a separate improvement item.
Contributor
Author
|
Huzzah!! Thanks for the thorough testing y'all! 🏆 |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6571/ |
cee-chen
added a commit
to elastic/kibana
that referenced
this pull request
Feb 9, 2023
## Summary `eui@74.0.1` ⏩ `eui@74.0.2` ___ ## [`74.0.2`](https://github.com/elastic/eui/tree/v74.0.2) **Bug fixes** - Fixed `EuiCard` to ensure `onClick` method only runs once when `title` contains a React node ([#6551](elastic/eui#6551)) - Fixed `EuiSelectable` options with incorrect `aria-posinset` indices when rendered with group labels not at the start of the array ([#6571](elastic/eui#6571)) - Fixed a bug with `EuiSearchBar` where filters with `multiSelect: false` were not able to select a new option when an option was already selected ([#6577](elastic/eui#6577)) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
1Copenut
added a commit
to elastic/kibana
that referenced
this pull request
Feb 14, 2023
## Summary `eui@74.0.2` ⏩ `eui@75.0.0` ___ ## [`75.0.0`](https://github.com/elastic/eui/tree/v75.0.0) - `EuiFlyout`s now automatically shard all fixed `EuiHeader`s on the page. This means that interactions (mouse & keyboard) with items inside `EuiHeader`s when flyouts are open will no longer trigger focus fighting ([#6566](elastic/eui#6566)) - `EuiFlyout`s now read out detailed screen reader dialog instructions and hints on open ([#6566](elastic/eui#6566)) **Bug fixes** - Fixed `EuiSelectable` options with incorrect `aria-posinset` indices when rendered with group labels not at the start of the array ([#6571](elastic/eui#6571)) - Fixed a bug with `EuiSearchBar` where filters with `multiSelect: false` were not able to select a new option when an option was already selected ([#6577](elastic/eui#6577)) **Breaking changes** - Removed the ability to customize the `role` prop of `EuiFlyout`s. `EuiFlyout`s should always be dialog roles for screen reader consistency. ([#6566](elastic/eui#6566)) - Removed `closeButtonAriaLabel` prop from `EuiFlyout` - use `closeButtonProps['aria-label']` instead ([#6566](elastic/eui#6566)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
justinkambic
pushed a commit
to justinkambic/kibana
that referenced
this pull request
Feb 23, 2023
## Summary `eui@74.0.2` ⏩ `eui@75.0.0` ___ ## [`75.0.0`](https://github.com/elastic/eui/tree/v75.0.0) - `EuiFlyout`s now automatically shard all fixed `EuiHeader`s on the page. This means that interactions (mouse & keyboard) with items inside `EuiHeader`s when flyouts are open will no longer trigger focus fighting ([elastic#6566](elastic/eui#6566)) - `EuiFlyout`s now read out detailed screen reader dialog instructions and hints on open ([elastic#6566](elastic/eui#6566)) **Bug fixes** - Fixed `EuiSelectable` options with incorrect `aria-posinset` indices when rendered with group labels not at the start of the array ([elastic#6571](elastic/eui#6571)) - Fixed a bug with `EuiSearchBar` where filters with `multiSelect: false` were not able to select a new option when an option was already selected ([elastic#6577](elastic/eui#6577)) **Breaking changes** - Removed the ability to customize the `role` prop of `EuiFlyout`s. `EuiFlyout`s should always be dialog roles for screen reader consistency. ([elastic#6566](elastic/eui#6566)) - Removed `closeButtonAriaLabel` prop from `EuiFlyout` - use `closeButtonProps['aria-label']` instead ([elastic#6566](elastic/eui#6566)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #6565
This bug was occurring whenever group labels existed in the
optionsarray that were not located at the start of the array.QA
<li>items in the first example.aria-posinsetindices before and after the group label(s)General checklist