Replace remark-parse with remark-parse-no-trim#6482
Merged
cee-chen merged 3 commits intoelastic:mainfrom Dec 14, 2022
Merged
Conversation
- in order to remove `trim@0.0.1` security warning that downstream consumers receive
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6482/ |
breehall
approved these changes
Dec 14, 2022
Contributor
breehall
left a comment
There was a problem hiding this comment.
This is great! I QA'd (if that's even a word) with the Markdown Editor and Markdown Format pages in the PR preview and in prod.
Contributor
Author
I'm gonna verb it as one even if it isn't! 😆 Thanks Bree! |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6482/ |
jbudz
pushed a commit
to elastic/kibana
that referenced
this pull request
Dec 22, 2022
## Summary `eui@71.0.0` ⏩ `eui@72.0.0` --- ## [`72.0.0`](https://github.com/elastic/eui/tree/v72.0.0) - Added the `customQuickSelectRender` render prop to `EuiSuperDatePicker`, which allows customizing the Quick Select popover ([#6382](elastic/eui#6382)) - `EuiFilePicker` styles have been updated to look more like an interactive element. ([#6479](elastic/eui#6479)) - Added a third argument to `EuiSelectable`'s `onChange` callback. The single `option` object that triggered the `onChange` event is now also passed to consumers with its most recent `checked` state ([#6487](elastic/eui#6487)) **Bug fixes** - `EuiTabs` now passes `size` and `expand` to all children using a React context provider. ([#6478](elastic/eui#6478)) - Fixed security warnings caused by `trim@0.0.1` sub-dependency ([#6482](elastic/eui#6482)) **Breaking changes** - Removed `size` and `expand` props from `EuiTab` ([#6478](elastic/eui#6478)) ## [`71.1.0`](https://github.com/elastic/eui/tree/v71.1.0) **Deprecations** - Renamed `EuiPageSideBarProps` to `EuiPageSideBarProps_Deprecated`, to reduce usage/confusion with `EuiPageSidebar` ([#6468](elastic/eui#6468)) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR does not fully address #5543, but resolves the underlying issue being described (security issues caused by
remark-parse's use oftrim@0.0.1).Simply upgrading
remark-parseis non-trivial due to all the reasons outlined in #5543 (comment), but it looks like GitHub's docs team at some point released a fork ofremark-parse@8.0.3without the trim dependency/security warnings, which is exactly what we need for an interim solution.QA
General checklist