[EuiPortal] Revert function component change while maintaining SSR fix#6105
Merged
cee-chen merged 6 commits intoelastic:mainfrom Aug 4, 2022
Merged
[EuiPortal] Revert function component change while maintaining SSR fix#6105cee-chen merged 6 commits intoelastic:mainfrom
cee-chen merged 6 commits intoelastic:mainfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6105/ |
2 tasks
chandlerprall
approved these changes
Aug 4, 2022
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Confirmed over slack this resolves the reproducible issues, and as the description notes we have high hopes for the flaky tests.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6105/ |
This was referenced Aug 4, 2022
yuliacech
pushed a commit
to yuliacech/eui
that referenced
this pull request
Aug 23, 2022
elastic#6105) * Revert "[EuiPortal] convert to a function component, fix ssr bug (elastic#6055)" This reverts commit 3aacaf9. * Re-revert / keep portal test changes * Restore `data-euiportal` attr for snapshot purposes * Restore SSR bugfix + add SSR tests * Changelog * Skip failing Cypress test that doesn't apply to class component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #6055, keeps #5656 closed
We're seeing a lot of portal issues in elastic/kibana#136865 - particularly around Enzyme and EuiTooltips, as well as intermittent E2E/FTR
StaleElementReferenceError: stale element reference: element is not attached to the page documenterrors. Our best guesstimation that is how to do with Enzyme handles constructor vs mount cycles, and that the FTR issues are due to us re-instantiating newdocument.createElements instead of using a single reference.This PR reverts the function component change in order to unblock the Kibana upgrade while maintaining the SSR fix and
data-euiportalattribute.Checklist