[Docs] Add new "Theming / Sizing" page#5326
Merged
cchaos merged 30 commits intoelastic:masterfrom Oct 28, 2021
Merged
Conversation
added 29 commits
September 29, 2021 15:37
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5326/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5326/ |
thompsongl
approved these changes
Oct 28, 2021
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
LGTM! Checked it out in all the browsers
Contributor
Author
|
🙇♀️ Thank you @thompsongl ! I'm going to merge this now, like before, so we can just continue on. We can always tweak later. |
ym
pushed a commit
to ym/eui
that referenced
this pull request
Oct 29, 2021
* Added Sizing page * Add subsections and use new _values * Deleting all old Sass typography * Added callout in Sass page and easier customization of ValuesTable columns * Cleanup including adding `valign` as a top level configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly same procedure as the others.
I did also add a little more flexibility to the ValuesTable component as needed.
Sass docs
I realized I'm not directing users from the old Sass page to the new ones so I added this callout.
Checklist
[ ] Checked Code Sandbox works for any docs examples[ ] Added or updated jest and cypress tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes[ ] A changelog entry exists and is marked appropriately