[EuiDataGrid] Fix large density not increasing font size on Amsterdam theme#5320
[EuiDataGrid] Fix large density not increasing font size on Amsterdam theme#5320cee-chen merged 6 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5320/ |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5320/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5320/ |
elizabetdev
left a comment
There was a problem hiding this comment.
Tested in Chrome, Safari, Edge, and Firefox. LGTM! 🎉
|
Oh shoot, @miukimiu's right. Sorry @constancecchen I gave you bad intel. I do think jumping from 16px to 18 is a bit drastic though, so I'd recommend applying the change in teh Amsterdam overrides like she suggested. Sorry |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5320/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5320/ |
elizabetdev
left a comment
There was a problem hiding this comment.
Thanks, @constancecchen! Tested again and LGTM! 🎉
|
Wahoo! Thanks y'all for learning me some theming differences! |
… theme (elastic#5320) * Fix large density not increasing in fontSize on Amsterdam theme * Add changelog entry * Switch to Amsterdam override
Summary
euiFontSizeis 14px on Amsterdam but 16px on legacy - we should specifyeuiFontSizeMif we want a 16px font size on expanded density data grids.Before
before.mp4
After
after.mp4
Checklist
- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Added or updated jest and cypress tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes