[Docs] Separated out Typography to its own page#5300
Merged
cchaos merged 30 commits intoelastic:masterfrom Oct 26, 2021
Merged
Conversation
added 25 commits
September 29, 2021 15:37
…n JS or Sass theming language
…on in docs rather that sass-loader
This reverts commit f3eccfb.
…rgb`" This reverts commit 2db22a4.
…_setup_and_breakpoints
…_typography # Conflicts: # src-docs/src/components/with_theme/theme_context.tsx # src-docs/src/routes.js # src-docs/src/views/guidelines/sass.js # src-docs/src/views/theme/_components/_theme_values_table.tsx # src-docs/src/views/theme/_json/_get_json_vars.js # src-docs/src/views/theme/_json/eui_theme_dark.json # src-docs/src/views/theme/_json/eui_theme_light.json # src-docs/src/views/theme/borders/_border_js.tsx # src-docs/src/views/theme/breakpoints/_breakpoints_js.tsx # src-docs/src/views/theme/breakpoints/breakpoints.tsx # src-docs/src/views/theme/customizing/_border.js # src-docs/src/views/theme/customizing/_breakpoints.js # src-docs/src/views/theme/values.js
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5300/ |
elizabetdev
reviewed
Oct 26, 2021
Contributor
elizabetdev
left a comment
There was a problem hiding this comment.
It's looking good. 😎
But I noticed there's not a section for font scale when the language selector is set to CSS-in-JS. Is it something you're planning to add?
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5300/ |
thompsongl
approved these changes
Oct 26, 2021
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
Looks good!
Confirmed Elizabet's requests were resolved
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5300/ |
ym
pushed a commit
to ym/eui
that referenced
this pull request
Oct 29, 2021
* Added Typography page * Deleting all old Sass typography
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply just docs in this one
Checklist
[ ] Props have proper autodocs and playground toggles[ ] Checked Code Sandbox works for any docs examples[ ] Added or updated jest and cypress tests[ ] Checked for breaking changes and labeled appropriately[ ] A changelog entry exists and is marked appropriately