[EuiComboBox] Fixed options list misalignment#4607
[EuiComboBox] Fixed options list misalignment#4607thompsongl merged 4 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4607/ |
|
jenkins test this Somewhat confused about the cause of this snapshot failure: - style="top: 16px; left: -22px; z-index: 2000; will-change: transform, opacity;"
+ style="top: 16px; left: -22px; will-change: transform, opacity; z-index: 2000;" |
|
This isn't up to date with master. That change came from #4590 |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4607/ |
|
Hmm, that was weird, I thought I was up to date at the time of submitting this PR. Please try again, I've tried running the test locally this time. |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4607/ |
|
Running CI again to be safe jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4607/ |
thompsongl
left a comment
There was a problem hiding this comment.
Thanks, @wenchonglee!
Summary
Fixes #4472.
@chandlerprall explained how to reproduce the problem and why it is happening
#4472 (comment)
To test it on the docs page, use devtools to manually remove enough elements so that only 1
EuiComboBoxis left, then mimic the clip shared in the issue.Checklist
- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes