[EuiPopover] Don't apply willChange to popover after it is done opening & animating#4590
Merged
chandlerprall merged 3 commits intoelastic:masterfrom Mar 3, 2021
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4590/ |
cchaos
reviewed
Mar 2, 2021
Contributor
cchaos
left a comment
There was a problem hiding this comment.
👍 LGTM. Thanks for making this change. I checked in Chrome, FF and Safari and they all look crisp and the DnD is visible.
Contributor
|
Tested in Chrome 88, Firefox, Safari, and Edge. Looks good. |
a0fdf68 to
533726b
Compare
Contributor
Author
|
Tested in Android Chrome & added a changelog. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4590/ |
thompsongl
approved these changes
Mar 2, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4590/ |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft mode as I've only tested this in Chrome on Mac, but otherwise ready for review.
Fixes #4574. Caroline noticed that the
will-changestyle on the popover panel broke thedisplay: fixedusage by drag&drop. This update dynamically addswill-changeonly during the popover's initial open animation, removing it after any transitions/animations have finished.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes