[Elastic charts] Improve crosshair styles#4503
Merged
elizabetdev merged 2 commits intoelastic:masterfrom Feb 10, 2021
Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4503/ |
4 tasks
cchaos
approved these changes
Feb 9, 2021
Contributor
cchaos
left a comment
There was a problem hiding this comment.
Looks great in both themes. Had a quick question about the original theme key.
| strokeWidth: 1, | ||
| dash: [4, 4], | ||
| }, | ||
| crossLine: { |
Contributor
There was a problem hiding this comment.
So is the line: key above this still valid or should it be removed?
Contributor
Author
There was a problem hiding this comment.
It's still valid. The crossLine appears when tooltip="cross" is passed (horizontal crossing line). And the line is the default vertical crosshair.
Contributor
|
Facing this error when making a |
Contributor
|
@akashgp09 There was an update to the Elastic-Charts dependency. Be sure to rerun |
Contributor
|
thanks 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #4308.
24.5.1crosshair.crossLine./elastic-charts/time-seriesexample.Issue to address in a future PR
I notice an issue with the crosshair. When grid lines are visible the crosshair hides behind those lines. I opened a PR in Elastic Charts repo to address this issue: elastic/elastic-charts#1021.
Before
As we can see, the crosshair was too light and almost invisible.
Screen.Recording.2021-02-09.at.03.53.PM.mov
After
Now, the crosshair looks better. You can also notice that there's an issue that I mentioned above (the crosshair hides behind the grid lines). This must be addressed in a future PR.
Screen.Recording.2021-02-09.at.03.55.PM.mov
How to test
Go to https://eui.elastic.co/pr_4503/#/elastic-charts/time-series. Interact with the chart. You can also change the chart type:
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs and **[playground toggles](https://github.com/elastic/eui/blob/master/wiki/documentation-guidelines.md#adding-playground-toggles)**[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes[ ] A changelog entry exists and is marked appropriately