style(crosshair): add z-index to crosshair line#1021
Merged
nickofthyme merged 6 commits intoelastic:masterfrom Feb 10, 2021
Merged
style(crosshair): add z-index to crosshair line#1021nickofthyme merged 6 commits intoelastic:masterfrom
nickofthyme merged 6 commits intoelastic:masterfrom
Conversation
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #1021 +/- ##
==========================================
- Coverage 72.50% 72.48% -0.03%
==========================================
Files 363 379 +16
Lines 11167 10789 -378
Branches 2431 2205 -226
==========================================
- Hits 8097 7820 -277
+ Misses 3056 2866 -190
- Partials 14 103 +89
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
markov00
approved these changes
Feb 10, 2021
Contributor
Author
|
I tested and it looks good to me the crosshairs above points and circles. I did a quick research and most of the charts I found, have the crosshair above circles. Highcharts seems to be an expectation. |
Collaborator
|
🎉 This PR is included in version 24.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a z-index to the crosshair line.
While working on elastic/eui#4503, I found that the crosslines hide behind the vertical grid lines.
Before
When the vertical grid lines are visible, the crosshairs stay behind the grid lines:
Screen.Recording.2021-02-09.at.01.46.PM.mov
After
With the z-index the crosshairs are now visible when we're on top of a vertical grid line:
Screen.Recording.2021-02-09.at.01.50.PM.mov
Checklist
Delete any items that are not applicable to this PR.
src/index.ts(and stories only import from../srcexcept for test data & storybook)