[EuiButtonGroup] Fix position for EuiScreenReaderOnly#4189
Merged
thompsongl merged 3 commits intoelastic:masterfrom Oct 28, 2020
Merged
[EuiButtonGroup] Fix position for EuiScreenReaderOnly#4189thompsongl merged 3 commits intoelastic:masterfrom
thompsongl merged 3 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
I couldn't replicate this in our docs even with changing the layouts to different positions. But it at least doesn't have any affect on normal layouts. |
Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4189/ |
cchaos
added a commit
to andreadelrio/eui
that referenced
this pull request
Nov 4, 2020
* [EuiButtonGroup] Fix position for EuiScreenReaderOnly * cl * Update src/components/button/button_group/_button_group.scss Co-authored-by: Greg Thompson <thompson.glowe@gmail.com> Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the recent Kibana upgrade it was found that some nested congregation of different display positions of elements can cause a weird overflow issue when used in conjunction with EuiButtonGroup and the EuiScreenReaderOnly component.
This is a quick fix by adding
position: relativeto the EuiButtonGroup to ensure theabsolutepositioned EuiScreenReaderOnly elements are positioned against it and not some other relative parent.Checklist
[ ] Check against all themes for compatibility in both light and dark modes[ ] Checked in mobile[ ] Props have proper autodocs[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes