Skip to content

[EuiSelectable] Fix focus management bug#4152

Merged
myasonik merged 5 commits intoelastic:masterfrom
myasonik:fix-searchable-dbl-click
Oct 19, 2020
Merged

[EuiSelectable] Fix focus management bug#4152
myasonik merged 5 commits intoelastic:masterfrom
myasonik:fix-searchable-dbl-click

Conversation

@myasonik
Copy link
Copy Markdown
Contributor

@myasonik myasonik commented Oct 16, 2020 •
edited
Loading

Summary

Fixes #4128 and fixes #4147

1000 points to @chandlerprall for helping hunt down this fix

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Oct 16, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_4152/

@myasonik
Copy link
Copy Markdown
Contributor Author

myasonik commented Oct 16, 2020

jenkins test this

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Oct 16, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_4152/

@cchaos
Copy link
Copy Markdown
Contributor

cchaos commented Oct 19, 2020

Has anyone also verified that this fixes the issue in Kibana?

chandlerprall
chandlerprall reviewed Oct 19, 2020
View reviewed changes
@myasonik
Copy link
Copy Markdown
Contributor Author

myasonik commented Oct 19, 2020

@cchaos Confirmed in Kibana this PR solves the issues over there. Good call.

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Oct 19, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_4152/

chandlerprall
chandlerprall suggested changes Oct 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changelog nit, otherwise this LGTM

cchaos
cchaos approved these changes Oct 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @myasonik ! Tested on the docs site, and the implementation where I saw it before is fixed now. Just a comment about the CL.

@chandlerprall Should this get a backport for Kibana 7.10?

@chandlerprall
Copy link
Copy Markdown
Contributor

chandlerprall commented Oct 19, 2020

@chandlerprall Should this get a backport for Kibana 7.10?

Works for me, seems worth getting ahead of instead of waiting for someone to notice & ask.

Michail Yasonik and others added 2 commits October 19, 2020 14:12
@cchaos
Update CHANGELOG.md
9d56fd2 
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Move bug fix CL entry to bug fix section
db118c4
@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Oct 19, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_4152/

@myasonik myasonik merged commit 9e028d8 into elastic:master Oct 19, 2020
@myasonik myasonik deleted the fix-searchable-dbl-click branch October 19, 2020 20:35
This was referenced Oct 20, 2020
Closed
Merged
@thompsongl thompsongl mentioned this pull request Oct 22, 2020
Merged
kshitij86 added a commit to kshitij86/eui that referenced this pull request Nov 29, 2020
@kshitij86 @cchaos
[EuiSelectable] Fix focus management bug (elastic#4152)
db8e3d9 
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
@afharo afharo mentioned this pull request Aug 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@chandlerprall chandlerprall chandlerprall requested changes

@cchaos cchaos cchaos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

@myasonik @kibanamachine @cchaos @chandlerprall