Deprecating EuiKeyboardAccessible by myasonik · Pull Request #4135 · elastic/eui

myasonik · 2020-10-14T22:39:09Z

Summary

Closes #3838. After this PR is merged, should update the deprecation schedule to include removing EuiKeyboardAccessible and create another issue for addressing EuiBasicTable's a11y issues which are outside the scope of this deprecation.

Adds docs about deprecation

Fixes EuiCodeEditor

Though EuiCodeEditor didn't use EuiKeyboardAccessible, because it mentioned it in the comments, it came up in this work. It used EuiKeyboardAccessible as a template for how to fix a problem that was better fixed other ways.

Fixes EuiStepsHorizontal

While removing the use of EuiKeyboardAccessible, also took the opportunity to fix up a few other a11y issues with the component, simplify its semantics, and align its string usage across all instances.

Ignores EuiBasicTable

EuiBasicTable uses EuiKeyboardAccessible but unwinding that decision would be a whole can of worms. To deprecate EuiKeyboardAccessible as quickly as possible, pushing off any EuiBasicTable work till a decision on how to deal with it can be reached.

Checklist

src/components/steps/step_horizontal.test.tsx

kibanamachine · 2020-10-14T23:01:39Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_4135/

kibanamachine · 2020-10-15T15:27:29Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_4135/

CHANGELOG.md

src-docs/src/views/accessibility/accessibility_example.js

src/components/steps/step_number.tsx

src/components/steps/step_horizontal.tsx

…oardAccessible

kibanamachine · 2020-10-15T19:53:25Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_4135/

kibanamachine · 2020-10-15T20:31:56Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_4135/

kibanamachine · 2020-10-15T20:58:26Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_4135/

thompsongl

Couple small things
+1 to finding a way around the li click event pass-through

src/components/steps/step_strings.tsx

CHANGELOG.md

cchaos · 2020-10-19T13:58:41Z

One thing real quick is that CI is throwing this error because you probably forgot to change a token key when copy/pasting.

18:26:55 Token euiStepStrings.warning has two differing defaults:
18:26:55 Step {number} has warnings
18:26:55 Step {number}: {title} has warnings

cchaos

The EuiStep rendering issues all seem to be fixed and display as they did before. 👍 CI is having some issues though, so be sure to fix those.

CHANGELOG.md

thompsongl

Looks good to merge after these changes

src/components/steps/step_strings.tsx

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>

kibanamachine · 2020-10-19T16:23:58Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_4135/

CHANGELOG.md

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

kibanamachine · 2020-10-19T18:07:45Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_4135/

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>

myasonik added accessibility deprecations PRs that contains deprecations. Add them to the deprecations meta ticket after merge. labels Oct 14, 2020

myasonik commented Oct 14, 2020

View reviewed changes

src/components/steps/step_horizontal.test.tsx Outdated Show resolved Hide resolved

myasonik force-pushed the deprecate-EuiKeyboardAccessible branch from c0c515f to f7cdaf4 Compare October 15, 2020 15:04

deprecating euikeyboardaccessible

eed5d59

myasonik force-pushed the deprecate-EuiKeyboardAccessible branch from f7cdaf4 to eed5d59 Compare October 15, 2020 15:05

myasonik marked this pull request as ready for review October 15, 2020 15:05

cchaos suggested changes Oct 15, 2020

View reviewed changes

Michail Yasonik added 2 commits October 15, 2020 15:24

pr feedback

18deb6d

Merge remote-tracking branch 'upstream/master' into deprecate-EuiKeyb…

6436767

…oardAccessible

Adding space between callout and text

64b5be6

Prettier fix

6cb8210

myasonik requested review from cchaos and thompsongl October 15, 2020 21:24

thompsongl reviewed Oct 15, 2020

View reviewed changes

src/components/steps/step_strings.tsx Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

Michail Yasonik added 2 commits October 16, 2020 17:55

fixing style and title regressions

7f6a6fa

Merge remote-tracking branch 'upstream/master' into pr/4135

8a7dcd3

myasonik requested a review from thompsongl October 16, 2020 22:00

cchaos approved these changes Oct 19, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

thompsongl approved these changes Oct 19, 2020

View reviewed changes

src/components/steps/step_strings.tsx Outdated Show resolved Hide resolved

src/components/steps/step_strings.tsx Outdated Show resolved Hide resolved

src/components/steps/step_strings.tsx Outdated Show resolved Hide resolved

Apply suggestions from code review

258538f

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>

cchaos reviewed Oct 19, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

312e2c4

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

myasonik merged commit 33126c8 into elastic:master Oct 19, 2020

myasonik deleted the deprecate-EuiKeyboardAccessible branch October 19, 2020 18:38

This was referenced Oct 21, 2020

[EuiStepHorizontal] needs to extend HTMLButtonElement types #4164

Closed

Upgrade EUI to v30.1.1 elastic/kibana#81499

Merged

kshitij86 added a commit to kshitij86/eui that referenced this pull request Nov 29, 2020

Deprecating EuiKeyboardAccessible (elastic#4135)

00c9384

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>

myasonik mentioned this pull request Apr 5, 2021

[EuiBasicTable] Trigger onClick on keypress not keyup #4685

Closed

thompsongl mentioned this pull request Jun 3, 2021

Upgrade EUI to v34.3.0 elastic/kibana#101334

Merged

myasonik mentioned this pull request Jul 27, 2021

Remove all instances of EuiKeyboardAccessible elastic/kibana#106910

Merged

3 tasks

cchaos mentioned this pull request Feb 10, 2022

EuiStepsHorizontal tooltip #5621

Closed

Conversation

myasonik commented Oct 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Adds docs about deprecation

Fixes EuiCodeEditor

Fixes EuiStepsHorizontal

Ignores EuiBasicTable

Checklist

Uh oh!

Uh oh!

kibanamachine commented Oct 14, 2020

Uh oh!

kibanamachine commented Oct 15, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Oct 15, 2020

Uh oh!

kibanamachine commented Oct 15, 2020

Uh oh!

kibanamachine commented Oct 15, 2020

Uh oh!

thompsongl left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cchaos commented Oct 19, 2020

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thompsongl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Oct 19, 2020

Uh oh!

Uh oh!

kibanamachine commented Oct 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

myasonik commented Oct 14, 2020 •

edited

Loading

thompsongl left a comment •

edited

Loading