[Amsterdam] Tighten title line-heights#4133
Merged
cchaos merged 4 commits intoelastic:masterfrom Oct 15, 2020
Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4133/ |
cchaos
approved these changes
Oct 15, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
LGTM. Though Chrome is still doing something funky with the evaluation of REM unit line-heights and rounding. For example the H1 evaluates to the correct line-height pixel value, but not the rendered height:
And the ~32px line-heights are .0001 px off but rounding down...
But without completely changing how we calculate line-heights, I don't see anything we can do about that right now. Hopefully @miukimiu might be able to sort it out for us when she tackles the mixin.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4133/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the following EUI Title line heights:
lwas 48px, now 40pxmwas 40px, now 32pxxxxswas 24px, now 16pxNote: These line heights do not apply to the medium EuiText scale. i.e.
h1still uses a 48px line height. @cchaos mentioned that @miukimiu might be making changes to oureuiTextScalemixin for something related to our markdown editor.The following screenshot shows these changes (blue dot indicates the titles that changed)
Checklist
[ ] Check against all themes for compatibility in both light and dark modes[ ] Checked in Chrome, Safari, Edge, and Firefox[ ] Props have proper autodocs[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes