Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
|
Welcome @Phizzard 👋 |
cchaos
left a comment
There was a problem hiding this comment.
Also don't forget to check off or cross out items in the summary checklist. One additional thing you'll need to add is a changelog entry which you can find a link to in the checklist. Just be sure to follow the pattern in that file.
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
|
Oh and we'll need an additional Jest test for this new prop which you can add in the associated |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4096/ |
|
Jenkins, test this |
cchaos
left a comment
There was a problem hiding this comment.
Unfortunately, this isn't actually working because of the way the component renders.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4096/ |
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4096/ |
| block: 'euiToolTipAnchor--displayBlock', | ||
| }; | ||
|
|
||
| export const DISPLAY = Object.keys(displayToClassNameMap); |
There was a problem hiding this comment.
This isn't used anywhere, safe to remove.
| export const DISPLAY = Object.keys(displayToClassNameMap); |
|
|
||
| - Added `display` prop to `EuiTooltip` ([#4096](https://github.com/elastic/eui/pull/4096)) |
There was a problem hiding this comment.
| - Added `display` prop to `EuiTooltip` ([#4096](https://github.com/elastic/eui/pull/4096)) | |
| - Added `display` prop to `EuiTooltip` ([#4096](https://github.com/elastic/eui/pull/4096)) |
There was a problem hiding this comment.
Also, it looks like you'll need to merge master to get the updated changelog file and move this to the newest master section.
Summary
This feature adds a
displayprop to the EuiTooltip component to be a means of quick customization for handling display values, instead of manually adding a class into the propanchorClassName.A similar implementation of this exists in the EuiPopover component.
Checklist