Skip to content

Add displayAsText props to EuiDataGridColumn#3520

Merged
chandlerprall merged 14 commits intoelastic:masterfrom
ashikmeerankutty:datagrid/fix
Jun 2, 2020
Merged

Add displayAsText props to EuiDataGridColumn#3520
chandlerprall merged 14 commits intoelastic:masterfrom
ashikmeerankutty:datagrid/fix

Conversation

@ashikmeerankutty
Copy link
Copy Markdown
Contributor

@ashikmeerankutty ashikmeerankutty commented May 28, 2020 •
edited
Loading

Summary

Fixes #3421

Added a displayAsText prop that will be shown in column popover and sorting popover of EuiDataGrid.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
    - [ ] Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
    - [ ] Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented May 28, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ashikmeerankutty ashikmeerankutty changed the title Add displayAsText props to column type of EuiDataGrid Add displayAsText props to EuiDataGridColumn May 28, 2020
@chandlerprall chandlerprall self-requested a review June 1, 2020 18:48
chandlerprall
chandlerprall suggested changes Jun 1, 2020
View reviewed changes
ashikmeerankutty
ashikmeerankutty commented Jun 2, 2020
View reviewed changes
@ashikmeerankutty
Copy link
Copy Markdown
Contributor Author

ashikmeerankutty commented Jun 2, 2020

@chandlerprall Thanks for the suggestions. Changes committed 👍

chandlerprall
chandlerprall approved these changes Jun 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; Pulled and tested locally, will merge on green CI

@chandlerprall
Copy link
Copy Markdown
Contributor

chandlerprall commented Jun 2, 2020

jenkins test this

@chandlerprall chandlerprall mentioned this pull request Jun 2, 2020
Closed
@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Jun 2, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3520/

@chandlerprall chandlerprall merged commit d0c497b into elastic:master Jun 2, 2020
daveyholler pushed a commit to daveyholler/eui that referenced this pull request Jun 3, 2020
@ashikmeerankutty @daveyholler
Add displayAsText props to EuiDataGridColumn (elastic#3520)
79b636a 
* Add displayAsText props to column type

* Column selector must show dispalyAsTest if it exists

* Use displayAsText instead of id

* Add displayAsText to EuiDataGridSorting interface

* Added example in docs

* Add cl

* Rever changes

* Removed display as test

* Updated info of props

* Use displayValues to get displayAsText from id

* Move displayValues to data grid

* Updated comment
@thompsongl thompsongl mentioned this pull request Jun 3, 2020
Merged
@timroes
Copy link
Copy Markdown
Contributor

timroes commented Jun 7, 2020 •
edited
Loading

@ashikmeerankutty This PR missed applying displayAsText in one place. While it correctly shows in the Columns sorting/hiding popover and the "pick a field" popover in the sorting popover, it's not using the value inside the sorting popover itself, when you sort by that field:

screenshot-20200607-234754

name and latestPrice are still the id of the column.

cc @chandlerprall

@ashikmeerankutty
Copy link
Copy Markdown
Contributor Author

ashikmeerankutty commented Jun 8, 2020

@timroes Sorry I missed that. I was aware of this issue while creating this PR but I missed to comment about it.
The issue is that EuiDataGridColumnSortingDraggable is using id passed to it as the value inside popover. In this case should I create another prop for EuiDataGridColumnSortingDraggable to set the value

eui/src/components/datagrid/column_sorting.tsx

Lines 176 to 178 in 1bc2b29

<EuiDataGridColumnSortingDraggable
key={id}
id={id}

@timroes
Copy link
Copy Markdown
Contributor

timroes commented Jun 8, 2020

Yes that sounds right. And then we can just pass the display as string value to the too.

@ashikmeerankutty
Copy link
Copy Markdown
Contributor Author

ashikmeerankutty commented Jun 8, 2020

Yes that sounds right. And then we can just pass the display as string value to the too.

I will make a PR

@ashikmeerankutty ashikmeerankutty mentioned this pull request Jun 8, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chandlerprall chandlerprall chandlerprall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[EuiDataGrid] Columns popover should not only show ids

4 participants

@ashikmeerankutty @kibanamachine @chandlerprall @timroes