[EuiCodeBlockImpl] element creation event; testenv mock for tests#3405
Merged
thompsongl merged 10 commits intoelastic:masterfrom May 6, 2020
Merged
[EuiCodeBlockImpl] element creation event; testenv mock for tests#3405thompsongl merged 10 commits intoelastic:masterfrom
testenv mock for tests#3405thompsongl merged 10 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3405/ |
chandlerprall
suggested changes
Apr 30, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Two small things. Conversion looks great!
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3405/ |
9 tasks
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3405/ |
chandlerprall
approved these changes
Apr 30, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM! Verified code block's docs functionality remains the same, no console errors/warnings observed.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3405/ |
This was referenced May 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2842 by adding a
testenvmock to bypass React portal usage, which often causes problems with Jest tests. Kibana has its own mocks forEuiCodeandEuiCodeBlockthat can be removed.Closes #3156 by moving creation of the React portal target element to the mount lifecycle event (previously done during class instance construction). Conversion from React class component to function component for good measure.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for accessibility including keyboard-only and screenreader modes