Added axe tests to form controls, error boundaries and inner text doc pages#3096
Merged
snide merged 4 commits intoelastic:masterfrom Mar 24, 2020
Merged
Added axe tests to form controls, error boundaries and inner text doc pages#3096snide merged 4 commits intoelastic:masterfrom
snide merged 4 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Contributor
|
Hey @mridulgogia! Thanks for this PR! There's already a PR in progress that will supersede the Thanks! |
26 tasks
Contributor
|
jenkins test this |
Contributor
|
Jenkins test this |
cchaos
suggested changes
Mar 18, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3096/ |
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
snide
approved these changes
Mar 24, 2020
Contributor
snide
left a comment
There was a problem hiding this comment.
Verified changes were made and double checked. Merging.
Contributor
|
Thanks for the help @mridulgogia |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes progress on #2679
Automated Axe testing
Checklist
Forms
Utilities
-[ ] Check against all themes for compatibility in both light and dark modes