Skip to content

Add EuiDataGrid to automated accessibility testing#3077

Merged
snide merged 16 commits intoelastic:masterfrom
anishagg17:acce
Mar 18, 2020
Merged

Add EuiDataGrid to automated accessibility testing#3077
snide merged 16 commits intoelastic:masterfrom
anishagg17:acce

Conversation

@anishagg17
Copy link
Copy Markdown
Contributor

@anishagg17 anishagg17 commented Mar 14, 2020 •
edited
Loading

Summary

makes progress on #2679
Included tabIndex prop for EuiDataGrid

Layout

  • Page

Tabular content

  • Data grid
  • Data grid in-memory settings
  • Data grid schemas and popovers
  • Data grid styling and toolbar
  • Data grid control columns

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples
- [ ] Added or updated jest tests
- [ ] Checked for breaking changes and labeled appropriately

  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Mar 14, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

anishagg17
anishagg17 commented Mar 14, 2020
View reviewed changes
myasonik
myasonik suggested changes Mar 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your continued work on this ticket!

Tweaked a couple of your aria-label changes because we want really good examples here as lots of developers will just copy and paste them into their own code.

We might need to dig in a little further on the failures though. I left some questions here for now but can also dig into them myself on Monday.

@cchaos cchaos changed the title improved accessibility Add EuiDataGrid to automated accessibility testing Mar 14, 2020
anishagg17 and others added 2 commits March 14, 2020 21:51
@anishagg17 @myasonik
Update src-docs/src/views/datagrid/control_columns.js
7c55da7 
Co-Authored-By: Michail Yasonik <michail@yasonik.com>
@anishagg17 @myasonik
Update src-docs/src/views/datagrid/control_columns.js
9caa850 
Co-Authored-By: Michail Yasonik <michail@yasonik.com>
@myasonik myasonik mentioned this pull request Mar 15, 2020
Closed
26 tasks
myasonik
myasonik suggested changes Mar 16, 2020
View reviewed changes
@myasonik myasonik mentioned this pull request Mar 16, 2020
Merged
11 tasks
anishagg17 and others added 3 commits March 17, 2020 11:02
@anishagg17 @myasonik
Update scripts/a11y-testing.js
0f8fb45 
Co-Authored-By: Michail Yasonik <michail@yasonik.com>
@anishagg17 @snide
Update src-docs/src/views/page/page_content_center_with_side_bar.js
634ddc9 
Co-Authored-By: Dave Snider <dave.snider@gmail.com>
@anishagg17
Merge branch 'master' into acce
73595a8
myasonik
myasonik reviewed Mar 17, 2020
View reviewed changes
anishagg17 and others added 6 commits March 17, 2020 11:12
@anishagg17 @myasonik
Update src-docs/src/views/datagrid/container.js
8d0e942 
Co-Authored-By: Michail Yasonik <michail@yasonik.com>
@anishagg17 @myasonik
Update src/components/datagrid/data_grid.tsx
0209ac0 
Co-Authored-By: Michail Yasonik <michail@yasonik.com>
@anishagg17 @myasonik
Update CHANGELOG.md
db89d1a 
Co-Authored-By: Michail Yasonik <michail@yasonik.com>
@anishagg17
removed tabIndex
7f3bb92
@anishagg17
fixed control columns
7d08971
@anishagg17
updated try-catch,aria-label
ff5ff30
@anishagg17
Copy link
Copy Markdown
Contributor Author

anishagg17 commented Mar 18, 2020

all changes have been made

@myasonik
Copy link
Copy Markdown
Contributor

myasonik commented Mar 18, 2020

jenkins test this

myasonik
myasonik approved these changes Mar 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming build is green!

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Mar 18, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3077/

@snide snide merged commit 4b9c6cd into elastic:master Mar 18, 2020
@anishagg17 anishagg17 deleted the acce branch March 18, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@chandlerprall chandlerprall chandlerprall left review comments

@snide snide snide approved these changes

@myasonik myasonik myasonik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anishagg17 @kibanamachine @myasonik @chandlerprall @snide