EuiDroppable now accepts multiple children (TypeScript)#2634
Merged
thompsongl merged 1 commit intoelastic:masterfrom Dec 12, 2019
seeruk:master
Merged
EuiDroppable now accepts multiple children (TypeScript)#2634thompsongl merged 1 commit intoelastic:masterfrom seeruk:master
thompsongl merged 1 commit intoelastic:masterfrom
seeruk:master
Conversation
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Contributor
|
Thanks for the contribution! We'll get someone to give a review. |
Contributor
|
jenkins test this |
thompsongl
approved these changes
Dec 12, 2019
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
Thanks, @seeruk! ReactElement[] appears to be the correct way to handle this.
Contributor
Author
|
Just updated to resolve the conflict with the changelog. |
Contributor
|
jenkins test this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The type definitions for EuiDroppable don't seem to allow multiple children. You can't use examples from the docs, without surrounding multiple children in their own
<></>fragment node - this change attempts to remedy that issue.I'll be honest, I'm not sure if
ReactElement[]is the best type for this, I did try to useReactNode, but that prevented other parts of the type definition from working, whereasReactElement[]didn't stop anything else from working.A test case has been added.
Checklist
- [x] Checked in dark mode- [x] Checked in mobile- [x] Checked in IE11 and Firefox- [x] Props have proper autodocs- [x] Added documentation examples- [x] Checked for breaking changes and labeled appropriately- [x] Checked for accessibility including keyboard-only and screenreader modes