Change render signature to function from property#2397
Merged
timroes merged 1 commit intoelastic:masterfrom Oct 4, 2019
Merged
Change render signature to function from property#2397timroes merged 1 commit intoelastic:masterfrom
render signature to function from property#2397timroes merged 1 commit intoelastic:masterfrom
Conversation
15 tasks
thompsongl
approved these changes
Oct 3, 2019
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
LGTM, thanks.
@chandlerprall I couldn't find an EUI issue for tracking an eventual TS upgrade. Do you know of one/should we get one going?
Contributor
|
@thompsongl no, we do not have one yet |
snide
pushed a commit
to snide/eui
that referenced
this pull request
Oct 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I am currently preparing the TS 3.7 upgrade in Kibana (elastic/kibana#47188). There is currently one failure coming from EUI, that this PR fixes. It seems that newer TS versions make a difference between having a function (that
renderis in the base class) and an property assigned an arrow function, which we had in this typing. So TS 3.7 will fail on this on:Changing the typing here slightly (which should not have any other effect) prevents this error from happening. Since this should have no effect (except that you later might work with TS 3.7.0) I didn't add a changelog for that.
Note: There are a couple of more issues if you want to actually upgrade EUI to TS 3.7.0, that will need to be fixed, but this is the only one actually preventing consumers to upgrade to 3.7.0 later on, so I wanted to focus on this for now.
Checklist
[ ] Checked in dark mode[ ] Checked in mobile[ ] Checked in IE11 and Firefox[ ] Props have proper autodocs[ ] Added documentation examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes[ ] A changelog entry exists and is marked appropriately