EuiSelectable programmatic options updates#2390
Merged
thompsongl merged 4 commits intoelastic:masterfrom Oct 1, 2019
Merged
Conversation
chandlerprall
approved these changes
Sep 30, 2019
Contributor
|
Oh, and needs a changelog |
snide
pushed a commit
to snide/eui
that referenced
this pull request
Oct 10, 2019
* derive state form prop updates * docs * CL; docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2071 to allow
EuiSelectableto accept updates to theoptionsarray via programmatic prop updates.I think we'll ultimately want to write some hooks to deal with the overlap in logic and interaction that
EuiSelectablehas withEuiComboBox. Making each more pure would have some re-render prevention benefits, also.The docs update can be reverted if we feel it doesn't need to be there beyond this review.
Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes