Fix SuperDatePicker isPaused prop update (again).#2298
Merged
walterra merged 3 commits intoelastic:masterfrom Sep 7, 2019
Merged
Fix SuperDatePicker isPaused prop update (again).#2298walterra merged 3 commits intoelastic:masterfrom
walterra merged 3 commits intoelastic:masterfrom
Conversation
3 tasks
pugnascotia
reviewed
Sep 6, 2019
src/components/date_picker/super_date_picker/super_date_picker.test.js
Outdated
Show resolved
Hide resolved
pugnascotia
approved these changes
Sep 6, 2019
….test.js Co-Authored-By: Rory Hunter <pugnascotia@users.noreply.github.com>
4 tasks
thompsongl
pushed a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
Follow up to elastic#2250. While the approach to add componenDidUpdate() in the PR linked above was the right one, the way the interval was updated didn't work out as intended. The code didn't properly stop any previous running interval. This updated PR changes the code to call stopInterval() in any case similar to how onRefreshChange() works. I also added some more tests to run against the interval updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #2250.
While the approach to add
componenDidUpdate()in the PR linked above was the right one, the way the interval was updated didn't work out as intended. The code didn't properly stop any previous running interval. This updated PR changes the code to callstopInterval()in any case similar to howonRefreshChange()works. I also added some more tests to run against the interval updates.Checklist
Checked in dark modedoesn't touch DOMChecked in mobiledoesn't touch DOMChecked in IE11 and Firefoxdoesn't touch DOMProps have proper autodocsdoesn't change existing propsAdded documentation examplesdoesn't change featuresChecked for accessibility including keyboard-only and screenreader modes