dist/eui_charts_theme should be .js#2294
Merged
thompsongl merged 3 commits intoelastic:masterfrom Sep 6, 2019
Merged
Conversation
cchaos
reviewed
Sep 5, 2019
Contributor
cchaos
left a comment
There was a problem hiding this comment.
It's suppose to convert a .ts to .js? But how can it then be consumed as a TS file by Kibana?
Contributor
Author
|
I think we'll have to provide a |
Contributor
Author
|
Ok. It'll generate a |
Contributor
|
Most likely unrelated, but my IDE complains about not finding the file, even though it compiles correctly with the theme.
|
chandlerprall
approved these changes
Sep 6, 2019
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; pulled & built locally, pulled that build into an empty typescript project and confirmed could import with import { EUI_CHARTS_THEME_DARK } from '@elastic/eui/dist/eui_charts_theme'; , compile the typescript application, and execute with node
thompsongl
added a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
* output should be js * generate .d.ts file * CL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extra
.tssnuck in before the merge.Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes