Merged
Conversation
Contributor
Author
|
I'm considering adding 2 generics to export type PropsForAnchor<T, P = {}> = T &
AnchorHTMLAttributes<HTMLAnchorElement> & {
href?: string;
onClick?: MouseEventHandler<HTMLAnchorElement>;
} & P;
export type PropsForButton<T, P = {}> = T &
ButtonHTMLAttributes<HTMLButtonElement> & {
onClick?: MouseEventHandler<HTMLButtonElement>;
} & P;Worth it? |
chandlerprall
approved these changes
Sep 4, 2019
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM, thanks!!
Contributor
|
I like the generics idea, helps solidify the solution, prevents mistakes, and we could expand the type to take a 3rd argument of props to omit (hoping to avoid the one-off solutions) |
thompsongl
added a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
* button onclick clean up * clickable generics * CL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeScript clean up related to a button component using
NoArgCallback<void>foronClick. It instead needs to allow for aneventparam and discriminate betweenaandbuttonelement renders.The component was used as the base for 2 other components, so they also needed to be updated.
Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes