Adding href prop to EuiTab#2275
Merged
elizabetdev merged 9 commits intoelastic:masterfrom Sep 4, 2019
Merged
Conversation
cchaos
suggested changes
Sep 3, 2019
Contributor
cchaos
left a comment
There was a problem hiding this comment.
Thanks for converting to TS at the same time! Just have a couple comments.
cchaos
approved these changes
Sep 4, 2019
Contributor
cchaos
left a comment
There was a problem hiding this comment.
LGTM! Would like @thompsongl to double-check the TS.
Contributor
|
@miukimiu I made a PR for you to describe some TS conversion things: elizabetdev#1 If you want to walk through anything or just ask questions in the thread, I'm available for both. Overall, nice job! |
Contributor
|
Oh yeah, and can you add a jest test specifically for supplying an |
EuiTab href
Contributor
Author
|
@thompsongl thanks for the PR with the descriptions. It was really helpful. |
thompsongl
suggested changes
Sep 4, 2019
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
Per @cchaos last comment, let's add a snapshot test for when href is in use.
Ready to go after that
This was referenced Sep 5, 2019
thompsongl
pushed a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
* Tab comp in typescript, href prop and example * Improving code based on comments * Tab comp in typescript, href prop and example * Improving code based on comments * Updating changelog * typescripting * Adding a snapshot test for when href is in use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1844 by adding the href prop to EuiTab. This PR also includes:
Checklist