Merged
Conversation
cchaos
suggested changes
Aug 29, 2019
Contributor
cchaos
left a comment
There was a problem hiding this comment.
I don't think we need a Beta label. It's not that experimental and I think your paragraph about focus keyboard nav is explanation enough.
Just had a few notes.
cchaos
suggested changes
Sep 4, 2019
Contributor
cchaos
left a comment
There was a problem hiding this comment.
Just a couple spelling mistakes and you still need a changelog entry
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
cchaos
approved these changes
Sep 5, 2019
Contributor
cchaos
left a comment
There was a problem hiding this comment.
LGTM, just a nit on the CL
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
thompsongl
added a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
* first pass * snippet * comments * more spacing before window edge * Update src-docs/src/views/popover/popover_example.js Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com> * Update src-docs/src/views/popover/popover_example.js Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com> * CL * Update CHANGELOG.md Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The beginnings of
EuiInputPopoverwere merged so thatEuiSuggestand a compressed variant ofEuiRangecould use them in their respective feature branches.For the most part, it's a preconfigured
EuiPopoverwith some resizing hooks. Focus/a11y is largely dependent on the nature of the input provided, so no real assumptions have been made. With that in mind, I'm considering adding thebetatag to this. It's in master, but unused and undocumented. Adding documentation means it needs to provide some sense of its stability, and it's hard to tell with so few known and upcoming use cases; I could see the API changing a bit.Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes