Offset negative margin for max width inside container for super date picker#2236
Conversation
src/components/date_picker/super_date_picker/_super_date_picker.scss
Outdated
Show resolved
Hide resolved
|
I did a quick test in Kibana, and there's just an issue when the update button isn't included. You'll need to add the |
@cchaos can you please tell me exactly where in kibana you faced above issue? |
089f6d0 to
0b23f6d
Compare
…essary-marging-bcoz-of-nagtaive-marging-usage
@cchaos Thanks for finding that issue, i have updated the PR. I have tested in kibana, seems okay to me now. |
cchaos
left a comment
There was a problem hiding this comment.
Thanks @shahzad31 . Just had a small comment on the language used in you CL entry. Also you'll need to rebase with master to get updates to the CL. Once that's done, you're good to merge.
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
|
@shahzad31 I'll get this fixed for you, but the reason I had asked to rebase with master is because your CL entry is in the wrong location. It needed to be under the Master heading instead of associated with the wrong release.
No worries, though I'll fix it directly. |
…picker (elastic#2236) * offset negative margin for max width inside container * update change log * use constant for px value * handled no update button and refresh only button scenerios * Update CHANGELOG.md Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
Summary
resolves #2225
EuiSuperDatePicker when used inside full width FlexBox Group is leaving margin like in example below
It's because of negative margin which is being added because of small size gutter being used to separate refresh button from selector.
So for a full width we need to offset negative margin of 4 on both sides by adding 8px into max width.