Fix EuiStat invalid DOM nesting#2229
Merged
elizabetdev merged 8 commits intoelastic:masterfrom Aug 26, 2019
Merged
Conversation
Contributor
|
@miukimiu Don't forget to add a changelog. Look at previous entries. A couple tips.
|
Contributor
Author
snide
suggested changes
Aug 15, 2019
Contributor
snide
left a comment
There was a problem hiding this comment.
Small change should get you fixed.
snide
reviewed
Aug 15, 2019
myasonik
suggested changes
Aug 15, 2019
snide
added a commit
that referenced
this pull request
Aug 16, 2019
CL entry for the stat stuff shouldn't be in master yet. It's still in a PR over here #2229 @miukimiu Please add this back into the change log file in your branch.
myasonik
approved these changes
Aug 20, 2019
Contributor
myasonik
left a comment
There was a problem hiding this comment.
There's a small a11y issue that now VO users loose the bounding box of the content that's being read. That's not perfect but I think it's better than what we have today and I don't have any ideas that would keep the bounding box without significant hacks or significant work so I'm comfortable with the current solution for now.
thompsongl
pushed a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
CL entry for the stat stuff shouldn't be in master yet. It's still in a PR over here elastic#2229 @miukimiu Please add this back into the change log file in your branch.
thompsongl
pushed a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
* Fixes stat invalid DOM nesting * Putting animation back * Moving display block * Improving sctructure and accessibility * ScreenReaderOnly rendered as a single phrase * Loading reverse * Changelog and code refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2228
There was an invalid DOM nesting due to a
<p>tag nested within another<p>tag. The issue was fixed by replacing the<p>tag with a<span>.Checklist