Multiple fixes for mobile tables#1462
Merged
cchaos merged 15 commits intoelastic:masterfrom Feb 25, 2019
Merged
Conversation
chandlerprall
suggested changes
Jan 23, 2019
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Should we trigger a console.warn if a deprecated prop is used?
aa3537f to
f9078a7
Compare
chandlerprall
suggested changes
Jan 23, 2019
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
small TS change, otherwise proptypes and ts defs look great!
Contributor
Author
|
Sweet. Ok, then I'll update all other table examples to use the proper props. |
d495ff3 to
63a592b
Compare
davidcool6160
approved these changes
Feb 17, 2019
235f90a to
aa54cc8
Compare
Contributor
Author
|
Ok, I think I'm done with this PR finally. 🥇 @chandlerprall Can you do a double check mainly just on this file: https://github.com/elastic/eui/pull/1462/files#diff-cca6a37365f48c17b61c1ad941a710c1 and especially concerning the select all checkbox where I ended up having to append a |
chandlerprall
approved these changes
Feb 25, 2019
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changes still LGTM
added 14 commits
February 25, 2019 15:31
And added back in all the i18n stuff
1a4ec33 to
1a8a81a
Compare
41 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Better singular prop object
mobileOptions object accepts the following:
That means the following props are being deprecated:
mobileOptions.headermobileOptions.only = true&mobileOptions.header = falsemobileOptions.show = falsemobileOptions.fullWidthExample
2. The mobileOptions.header prop accepts a node for rendering
... Instead of using the CSS
content: attr(data-header)trick. It's displayed directly in the DOM. Fixes #1315cc @cjcenizal
3. EuiBasicTable properly adds support for the mobile version of "Select all"
Fixes #1036
Deprecation Notice
Again, this deprecates some of the responsive-only props in favor of the
mobileOptionsobject. However, it is currently not a breaking change. The old props will still work, but the object will override them if both are provided.Testing
So I've left all but the Responsive and Custom examples as they were, to ensure that these are still working. Then when I get approval of the new object prop, I will update all the examples to use the proper prop.
I also ran this through Kibana via
yarn linkand went through a bunch of table-heavy pages and didn't come up with any breaks. Though I didn't run it through any tests.Checklist
[ ] This required updates to Framer X components