Merged
Conversation
chandlerprall
approved these changes
Sep 11, 2018
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
LGTM, code review and aria-live investigations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1028
Possibly fixes #749
This adds some aria labeling to the search bar and table. Due to some funkiness with aria-live in various browsers at the moment some of it doesn't work (specifically re-reading the content after its been updated). However, this is how the aria-live spec says to do stuff.
Methods used
Searchbar now has an aria label that announces what it does and lets the user know if the content will auto update or not.
BasicTable now includes a caption which announces the amount of items present through
aria-live. In combo with search bar this should read as the content changes. However, right now that isn't the case due to the bugs mentioned above. Worst case scenario is that there is a hidden table caption that does nothing at the moment.https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Live_Regions
Checklist
This was checked in mobileThis was checked in IE11This was checked in dark modeAny props added have proper autodocs