explicit positional arguments in DSL generated classes#3233
Merged
miguelgrinberg merged 1 commit intoelastic:mainfrom Dec 19, 2025
Merged
explicit positional arguments in DSL generated classes#3233miguelgrinberg merged 1 commit intoelastic:mainfrom
miguelgrinberg merged 1 commit intoelastic:mainfrom
Conversation
github-actions bot
pushed a commit
that referenced
this pull request
Dec 19, 2025
(cherry picked from commit e8f2d04)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 19, 2025
(cherry picked from commit e8f2d04)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 19, 2025
(cherry picked from commit e8f2d04)
miguelgrinberg
added a commit
that referenced
this pull request
Dec 19, 2025
miguelgrinberg
added a commit
that referenced
this pull request
Dec 19, 2025
miguelgrinberg
added a commit
that referenced
this pull request
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3228
This change make positional arguments in generated DSL classes explicitly positional by adding a
/to the argument list.