Add most recently added fields as top-level exports#3078
Merged
miguelgrinberg merged 2 commits intoelastic:mainfrom Sep 19, 2025
Merged
Add most recently added fields as top-level exports#3078miguelgrinberg merged 2 commits intoelastic:mainfrom
miguelgrinberg merged 2 commits intoelastic:mainfrom
Conversation
3ceb829 to
2328072
Compare
pquentin
approved these changes
Sep 18, 2025
Member
pquentin
left a comment
There was a problem hiding this comment.
Thanks! LGTM.
Should this be code generated?
Contributor
Author
It should, ideally. But there is a mix of manual and generated classes in the import list, so the file cannot be fully generated. I'll see if I can add a unit test that ensures that all the generated fields can be imported, which should be easier to do. |
8f244c4 to
dd9588e
Compare
pquentin
approved these changes
Sep 19, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Sep 19, 2025
* Add most recently added fields as top-level exports * add unit test to ensure all fields are exported (cherry picked from commit 9c61068)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 19, 2025
* Add most recently added fields as top-level exports * add unit test to ensure all fields are exported (cherry picked from commit 9c61068)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 19, 2025
* Add most recently added fields as top-level exports * add unit test to ensure all fields are exported (cherry picked from commit 9c61068)
miguelgrinberg
added a commit
that referenced
this pull request
Sep 19, 2025
miguelgrinberg
added a commit
that referenced
this pull request
Sep 19, 2025
miguelgrinberg
added a commit
that referenced
this pull request
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indirect discovery while working on #3075 is that the most recent batch of
Fieldsubclasses were not included as top-level exports. This PR adds them.