Merged
Conversation
Closed
Mpdreamz
requested changes
Dec 28, 2020
Member
Mpdreamz
left a comment
There was a problem hiding this comment.
LGTM one failing code standards test though
[xUnit.net 00:00:16.2349559] Tests.CodeStandards.Descriptors.DescriptorMethodsTakingSingleValueTypeShouldBeNullable [FAIL]
Failed Tests.CodeStandards.Descriptors.DescriptorMethodsTakingSingleValueTypeShouldBeNullable [223 ms]
Error Message:
Expected breakingDescriptors to be empty, but found {"dateInterval on method Unit of Nest.RateAggregationDescriptor`1 is not nullable", "mode on method Mode of Nest.RateAggregationDescriptor`1 is not nullable"}.
Stack Trace:
- Fix breaking test - Add missing XML comments - Rename file
Contributor
Author
|
Thanks @Mpdreamz - Fixed up the test. Letting CI run and then will merge. |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2021
* Add support for rate aggregation * Add missing XML comments
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2021
* Add support for rate aggregation * Add missing XML comments
stevejgordon
added a commit
that referenced
this pull request
Jan 7, 2021
stevejgordon
added a commit
that referenced
this pull request
Jan 11, 2021
* Add support for rate aggregation (#5206) * Add support for rate aggregation * Add missing XML comments * Fix namespace in master Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to elastic/elasticsearch#61369 and elastic/elasticsearch#63687
Contributes to #5198