Conversation
This commit adds support for the string_stats aggregation introduced in Elasticsearch 7.6.0. It is a metric aggregation but does not implement IMetricAggregation because the type of Missing field is a string and not a double value. Missing is implemented as object as the hierarchy of metric aggregations will be changed as part of #4332, and Missing will be an object. The documentation for StringStats indicates that the distribution is returned in descending probability order, but are modelled as a JSON object. Following internal discussion, this is modelled as a dictionary on the response as it is considered this modelling will not diminish functionality. Closes #4369
Closed
Mpdreamz
reviewed
Feb 7, 2020
| { | ||
| // string stats aggregation | ||
| var minLength = reader.ReadInt32(); | ||
| reader.ReadNext(); // , |
Mpdreamz
approved these changes
Feb 7, 2020
Member
Mpdreamz
left a comment
There was a problem hiding this comment.
LGTM, Dictionary is a good middle ground in 7.x
russcam
added a commit
that referenced
this pull request
Feb 10, 2020
This commit adds support for the string_stats aggregation introduced in Elasticsearch 7.6.0. It is a metric aggregation but does not implement IMetricAggregation because the type of Missing field is a string and not a double value. Missing is implemented as object as the hierarchy of metric aggregations will be changed as part of #4332, and Missing will be an object. The documentation for StringStats indicates that the distribution is returned in descending probability order, but are modelled as a JSON object. Following internal discussion, this is modelled as a dictionary on the response as it is considered this modelling will not diminish functionality. Closes #4369 (cherry picked from commit cc45fb1)
Contributor
Author
|
ported to master 9917ff6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for the string_stats aggregation introduced in
Elasticsearch 7.6.0. It is a metric aggregation but does not implement
IMetricAggregation because the type of Missing field is a string and not a
double value. Missing is implemented as object as the hierarchy of
metric aggregations will be changed as part of #4332, and Missing
will be an object.
The documentation for StringStats indicates that the distribution is returned
in descending probability order, but are modelled as a JSON object. Following
internal discussion, this is modelled as a dictionary on the response as it is
considered this modelling will not diminish functionality.
Closes #4369