Conversation
This commit adds the histogram datatype to the client. The histogram datatype is available in Elasticsearch 7.6.0+ with at least a basic license level Closes #4358
Contributor
Author
|
I did consider adding a type to be able to index histogram values and counts. Thoughts? |
Closed
Contributor
|
The docs (https://www.elastic.co/guide/en/elasticsearch/reference/7.x/histogram.html) indicate the format for indexing is quite simple: I think a type to index this is probably worth it and quite simple to implement? |
Mpdreamz
approved these changes
Feb 7, 2020
Member
A type used for indexing would be good, however we would also need to make sure it works well with |
Contributor
Author
It being a simple type was my reason to not implement it 😄 Could add one in a follow up PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the histogram datatype to the client. The histogram datatype
is available in Elasticsearch 7.6.0+ with at least a basic license level
Closes #4358