Force selection of calendar or fixed intervals in date histo aggregations#3988
Merged
Force selection of calendar or fixed intervals in date histo aggregations#3988
Conversation
russcam
approved these changes
Aug 7, 2019
Contributor
russcam
left a comment
There was a problem hiding this comment.
LGTM.
Unsure of the best way to handle Interval -> CalendarInterval/FixedInterval with respect to usage tests; the pragma directives allow the tests to work for all 7.x versions, but it does mean that the use of Interval will be in documentation for all 7.x versions, because documentation is not generated for each minor version.
Mpdreamz
approved these changes
Aug 7, 2019
Member
Mpdreamz
left a comment
There was a problem hiding this comment.
LGTM, ideally the pragma disable/restore is only around the offending line setting .Interval() though
Co-Authored-By: Russ Cam <russ.cam@elastic.co>
codebrain
added a commit
that referenced
this pull request
Aug 16, 2019
russcam
pushed a commit
that referenced
this pull request
Sep 3, 2019
…ions (#3988) Implements elastic/elasticsearch#33727 (cherry picked from commit 9ba5d51)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements elastic/elasticsearch#33727