add support for missing_bucket on composite aggregation as per https:…#3420
Merged
add support for missing_bucket on composite aggregation as per https:…#3420
Conversation
russcam
reviewed
Oct 6, 2018
Contributor
russcam
left a comment
There was a problem hiding this comment.
Implementation looks good, had some questions about the Bogus change and commented SkipVersionAttribute
| .RuleFor(p => p.NumberOfContributors, f => Gimme.Random.Number(1, 200)) | ||
| .RuleFor(p => p.Ranges, f => Ranges.Generator.Generate()) | ||
| .RuleFor(p => p.Branches, f => Gimme.Random.ListItems(new List<string> { "master", "dev", "release", "qa", "test" }, 2)) | ||
| .RuleFor(p => p.Branches, f => Gimme.Random.ListItems(new List<string> { "master", "dev", "release", "qa", "test" })) |
Contributor
There was a problem hiding this comment.
Did this have any knock on for other tests (I believe terms_set used this field, IIRC)?
| * Be sure to read the Elasticsearch documentation on {ref_current}/search-aggregations-bucket-composite-aggregation.html[Composite Aggregation]. | ||
| */ | ||
| [SkipVersion("<6.1.0", "Composite Aggregation is only available in Elasticsearch 6.1.0+")] | ||
| //[SkipVersion("<6.1.0", "Composite Aggregation is only available in Elasticsearch 6.1.0+")] |
|
|
||
| //hide | ||
| [SkipVersion("<6.3.0", "Date histogram source only supports format starting from Elasticsearch 6.3.0+")] | ||
| //[SkipVersion("<6.3.0", "Date histogram source only supports format starting from Elasticsearch 6.3.0+")] |
russcam
pushed a commit
that referenced
this pull request
Oct 26, 2018
per elastic/elasticsearch#29465 (cherry picked from commit f7712ff)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elastic/elasticsearch#29465