add support for RemoteInfo API and adds cross cluster support to Inde…#2743
add support for RemoteInfo API and adds cross cluster support to Inde…#2743
Conversation
|
Technically |
russcam
left a comment
There was a problem hiding this comment.
A couple of minor nitpicks, otherwise LGTM 👍
| { | ||
| var enableRemoteClusters = client.ClusterPutSettings(new ClusterPutSettingsRequest | ||
| { | ||
| Transient = new M |
There was a problem hiding this comment.
I think it's be better to use the type here instead of the M alias, for documentation purposes
| public partial interface IElasticClient | ||
| { | ||
| /// <summary> | ||
| /// The cluster health API allows to get a very simple status on the health of the cluster. |
There was a problem hiding this comment.
I think this should use the remote info API summary?
The cluster remote info API allows to retrieve all of the configured remote cluster information.
| private static readonly char[] ClusterSeparator = {':'}; | ||
| internal string DebugDisplay => Type == null ? Name : $"{nameof(IndexName)} for typeof: {Type?.Name}"; | ||
|
|
||
| //TODO 6.0 make setters private and use constructor |
|
Implemented PR feedback as part of |
* Updated api gen to 5.4 and added a way to patch specification files through special *.patch.json companion files. Due to pending discusion on elastic/elasticsearch@e579629 :q! * updated x-pack spec to 5.4 * add codegen part for xpack info related APIs * Added support for Field Caps API * add support for RemoteInfo API and adds cross cluster support to IndexName * added support for SourceExists() * add skipversion, eventhough this API existed it was undocumented prior to 5.4 * expose word delimiter graph token filter as per elastic/elasticsearch#23327 * spaces=>tabs * expose num_reduce_phases as per elastic/elasticsearch#23288 * implemented XPackInfo() started on XPackUsage() * added response structure for XPackUsage() * change license date from DateTime to DateTimeOffset' * implement PR feedback on #2743 * remove explicit folder includes in csproj files
|
ported to |
…xName