Skip to content

chore: update ESM patching for apache-arrow#3294

Merged
JoshMock merged 3 commits into
mainfrom
drop-arrow-patch
May 20, 2026
Merged

chore: update ESM patching for apache-arrow#3294
JoshMock merged 3 commits into
mainfrom
drop-arrow-patch

Conversation

@JoshMock

@JoshMock JoshMock commented May 19, 2026

Copy link
Copy Markdown
Member

Ensures ESM patch still works now that apache-arrow is imported dynamically.

Also adds tests to keep coverage above threshold.

@prodsecmachine

prodsecmachine commented May 19, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@JoshMock JoshMock force-pushed the drop-arrow-patch branch from d74670d to bf6216a Compare May 19, 2026 19:32
@JoshMock JoshMock force-pushed the drop-arrow-patch branch from bf6216a to 103795c Compare May 20, 2026 13:52
@JoshMock JoshMock merged commit 99aa527 into main May 20, 2026
27 checks passed
@JoshMock JoshMock deleted the drop-arrow-patch branch May 20, 2026 14:36
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown

The backport to 9.4 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.4 9.4
# Navigate to the new working tree
cd .worktrees/backport-9.4
# Create a new branch
git switch --create backport-3294-to-9.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 99aa52793282c38ed6b73f22195d8cb496813b74
# Push it to GitHub
git push --set-upstream origin backport-3294-to-9.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.4

Then, create a pull request where the base branch is 9.4 and the compare/head branch is backport-3294-to-9.4.

@github-actions

Copy link
Copy Markdown
Contributor

AI Backport Resolver created a backport PR (no conflicts): #3295

JoshMock added a commit that referenced this pull request May 20, 2026
* chore: add sniffingTransport tests

* chore: add more bulk helper tests

* chore: update ESM patching for apache-arrow

(cherry picked from commit 99aa527)

Co-authored-by: Josh Mock <joshua.mock@elastic.co>
@JoshMock JoshMock mentioned this pull request May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants