Conversation
mshustov
reviewed
Jul 20, 2020
| } | ||
| return true | ||
| }) | ||
| if (foundTrue && foundFalse) { |
Contributor
There was a problem hiding this comment.
I can imagine an endpoint with false | 'some_string' parameter.
Member
Author
There was a problem hiding this comment.
I know, I'm being overcautious here :D
mshustov
approved these changes
Jul 20, 2020
Contributor
mshustov
left a comment
There was a problem hiding this comment.
are you going to release it as rc2?
are we still waiting for the ES team response on the deleteByNamespace interface?
Member
Author
Yes, I'll release as many as we need until we solve elastic/kibana#70431.
I've just asked, but we can merge this one in the meantime already. |
delvedor
added a commit
that referenced
this pull request
Jul 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ignoreparamater is part of the request options and not the request params.'true'andfalse'), this pr generates them asboolean.The type definition fix will be generated once in
master,7.x, and7.9.Related: elastic/kibana#72388 elastic/kibana#72289