Merged
Conversation
github-actions bot
pushed a commit
that referenced
this pull request
Mar 12, 2020
* Safe json parsing * Updated test
github-actions bot
pushed a commit
that referenced
this pull request
Mar 12, 2020
* Safe json parsing * Updated test
github-actions bot
pushed a commit
that referenced
this pull request
Mar 12, 2020
* Safe json parsing * Updated test
|
This breaks perfectly valid existing code: Consider the request: The response is: This will now throw a DeserializtionError on a perfectly valid response. It also occurs in many other contexts which depend on the data (such as |
Member
Author
|
Hi @matAtWork, please see #1408 (comment). |
|
Warning to other users: this PR introduces a breaking change that is dependent on the data in your ES index. More details are in the above issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a protection mechanism against malicious JSON documents, avoiding prototype pollution attacks.
Further reading: Square Brackets are the Enemy