Make sure the downsample step is not stuck#98477
Merged
elasticsearchmachine merged 2 commits intoelastic:mainfrom Aug 15, 2023
Merged
Make sure the downsample step is not stuck#98477elasticsearchmachine merged 2 commits intoelastic:mainfrom
elasticsearchmachine merged 2 commits intoelastic:mainfrom
Conversation
If the downsampling index exists but it's still downsampling we should invocate the downsample transport action again (and wire up the request listener such that the ILM listener gets notified of success or failure) This modifies the test to assert the ILM listener is invoked and removes an invariant that doesn't hold anymore in ILM (i.e. previously before but now we can, and do)
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
csoulios
pushed a commit
to csoulios/elasticsearch
that referenced
this pull request
Aug 18, 2023
If the downsampling index exists but it's still downsampling we should invocate the downsample transport action again (and wire up the request listener such that the ILM listener gets notified of success or failure) This modifies the test to assert the ILM listener is invoked and removes an invariant that doesn't hold anymore in ILM (i.e. previously before elastic#97557 but now we can, and do) Markin as non-issue as this hasn't been released yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the downsampling index exists but it's still downsampling we should invocate the downsample transport action again (and wire up the request listener such that the ILM listener gets notified of success or failure)
This modifies the test to assert the ILM listener is invoked and removes an invariant that doesn't hold anymore in ILM (i.e. previously before #97557 but now we can, and do)
Markin as non-issue as this hasn't been released yet.