Make AsyncSearchResponse use Chunked ToXContent streaming#98380
Merged
romseygeek merged 8 commits intoelastic:mainfrom Aug 16, 2023
Merged
Make AsyncSearchResponse use Chunked ToXContent streaming#98380romseygeek merged 8 commits intoelastic:mainfrom
romseygeek merged 8 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
DaveCTurner
reviewed
Aug 11, 2023
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
All looks fine to me but I'll leave the search folks to give it a final ok. I left some suggestions.
...lugin/core/src/main/java/org/elasticsearch/xpack/core/search/action/AsyncSearchResponse.java
Outdated
Show resolved
Hide resolved
...lugin/core/src/main/java/org/elasticsearch/xpack/core/search/action/AsyncSearchResponse.java
Outdated
Show resolved
Hide resolved
Comment on lines
+42
to
44
| protected RestStatus getRestStatus(Response response) { | ||
| return RestStatus.OK; | ||
| } |
server/src/main/java/org/elasticsearch/common/xcontent/ChunkedToXContentHelper.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Have updated based on @DaveCTurner's suggestions |
DaveCTurner
reviewed
Aug 15, 2023
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
Still looks fine to me but deserving of a final ok from someone in the search team too.
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-1 |
csoulios
pushed a commit
to csoulios/elasticsearch
that referenced
this pull request
Aug 18, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #95661