Remove unsafe default executor for transport responses#98131
Merged
elasticsearchmachine merged 1 commit intoelastic:mainfrom Aug 2, 2023
Merged
Conversation
Today `TransportResponseHandler` (and derivatives like `ActionListenerResponseHandler`) silently default to handling the response on the transport worker thread. This is not a safe default: we should only be avoiding forking for the most performance-critical things. This commit removes this unsafe default so that callers must always specify an executor, prompting implementors and reviewers to consider the threading model more deeply.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
approved these changes
Aug 2, 2023
ChrisHegarty
pushed a commit
that referenced
this pull request
Aug 9, 2023
Fix the compilation after merging #98131 which removed a constructor that we were using. The old constructor used the transport thread to execute the response. I checked all of the cases where the compilation failed and all of those places looked appropriate to run on the transport worker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today
TransportResponseHandler(and derivatives likeActionListenerResponseHandler) silently default to handling theresponse on the transport worker thread. This is not a safe default: we
should only be avoiding forking for the most performance-critical
things. This commit removes this unsafe default so that callers must
always specify an executor, prompting implementors and reviewers to
consider the threading model more deeply.