[ML] fix possible race condition in frequent item sets aggregation#95860
Merged
hendrikmuhs merged 2 commits intoelastic:mainfrom May 5, 2023
Merged
[ML] fix possible race condition in frequent item sets aggregation#95860hendrikmuhs merged 2 commits intoelastic:mainfrom
hendrikmuhs merged 2 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
przemekwitek
approved these changes
May 5, 2023
| consumerThread.start(); | ||
| producerThread.start(); | ||
| consumerThread.join(); | ||
| producerThread.join(); |
There was a problem hiding this comment.
Is it enough if the threads just finish?
Or should there be some assertion in the end checking the value of estimate bytes?
Author
There was a problem hiding this comment.
the purpose of the test is not hitting this line:
I was able to re-produce the CI issue with -Dtests.iters=1000 - but I don't want to check-in a loop.
Still, I should document ^this, will do.
Collaborator
💚 Backport successful
|
hendrikmuhs
pushed a commit
to hendrikmuhs/elasticsearch
that referenced
this pull request
May 5, 2023
…lastic#95860) Refactorings done in elastic#94023. improved memory management but also made it possible to run into a race condition in DelegatingCircuitBreaker. This change makes DelegatingCircuitBreaker thread-safe. This change is a quick-fix with low risk. Eventually DelegatingCircuitBreaker should be removed. Work on that is underway: elastic#89437. Under that circumstances the change is reasonable to me. The added locking overhead shouldn't be a problem, re-allocations happen rarely and there is just the disconnect case where 2 threads potentially access the structure at the same time. fixes elastic#95681
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 5, 2023
…95860) (#95879) Refactorings done in #94023. improved memory management but also made it possible to run into a race condition in DelegatingCircuitBreaker. This change makes DelegatingCircuitBreaker thread-safe. This change is a quick-fix with low risk. Eventually DelegatingCircuitBreaker should be removed. Work on that is underway: #89437. Under that circumstances the change is reasonable to me. The added locking overhead shouldn't be a problem, re-allocations happen rarely and there is just the disconnect case where 2 threads potentially access the structure at the same time. fixes #95681
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactorings done in #94023. improved memory management but also made it possible to run into a race condition in
DelegatingCircuitBreaker. This change makes DelegatingCircuitBreaker thread-safe.This change is a quick-fix with low risk. Eventually
DelegatingCircuitBreakershould be removed. Work on that is underway: #89437. Under that circumstances the change is reasonable to me. The added locking overhead shouldn't be a problem, re-allocations happen rarely and there is just thedisconnectcase where 2 threads potentially access the structure at the same time.#94023 hasn't been part of a release, therefore I mark this as non-issue, although technically this is a bug.
fixes #95681